fix(pi-cli): recover assistant text from message updates#930
Closed
fix(pi-cli): recover assistant text from message updates#930
Conversation
Deploying agentv with
|
| Latest commit: |
7ca47dc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://389ff895.agentv.pages.dev |
| Branch Preview URL: | https://fix-922-pi-cli-azure-empty-c.agentv.pages.dev |
Collaborator
Author
|
Closing because the reported pi-azure bug did not reproduce as a real Azure E2E failure in this environment. The parser edge case was reproducible, but not the user-facing red path from #922. I verified on main and on this branch with a real Azure-backed eval, and both passed. I’m filing a separate issue for the real Azure failure reproduced on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #922
Summary
message_updatestreaming events whenagent_end.messages[].contentis emptymessage_endfallback and add regression coverage for the streamed-delta caseRed
main, running a synthetic pi JSON stream withmessage_updatetext deltas and an emptyagent_endassistant message returned an assistant message with no contentbun --eval 'import { _internal } from "./packages/core/src/evaluation/providers/pi-cli.ts"; /* synthetic message_update + empty agent_end */'\n\n## Green\n- The same synthetic stream now returns assistant content2 + 2 = 4\n- Regression test added inpackages/core/test/evaluation/providers/pi-cli-tool-extraction.test.ts\n\n## Verification\n-bun test packages/core/test/evaluation/providers/pi-cli-tool-extraction.test.ts\n-bun test packages/core/test/evaluation/providers/targets.test.ts --test-name-pattern "pi-cli with azure subprovider and base_url"\n-bunx biome check packages/core/src/evaluation/providers/pi-cli.ts packages/core/test/evaluation/providers/pi-cli-tool-extraction.test.ts\n- pre-push hook passed: build, typecheck, lint, test, validate:examples\n