fix(core): remove camelCase target aliases#937
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
2a0376b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7aa800a.agentv.pages.dev |
| Branch Preview URL: | https://fix-azure-remove-camelcase-a.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #935.
Summary
TargetDefinitionso the public input type matches the new runtime contractWhy
#935 deprecated camelCase aliases but intentionally kept them working. This change completes that migration by enforcing snake_case-only target config.
Verification
bun test packages/core/test/evaluation/providers/targets.test.ts packages/core/test/evaluation/providers/cli-schema.test.ts packages/core/test/evaluation/validation/targets-validator.test.tsazure-> returnedOKclaude-cli-> returnedOKcopilot-cli-> returnedOKtargets.ts;bun run lintpassed in the branch worktree before push