Skip to content

fix(core): remove camelCase target aliases#937

Merged
christso merged 3 commits intomainfrom
fix/azure-remove-camelcase-aliases
Apr 5, 2026
Merged

fix(core): remove camelCase target aliases#937
christso merged 3 commits intomainfrom
fix/azure-remove-camelcase-aliases

Conversation

@christso
Copy link
Copy Markdown
Collaborator

@christso christso commented Apr 5, 2026

Follow-up to #935.

Summary

  • remove camelCase target aliases from target resolution and validation
  • reject camelCase target YAML fields instead of warning while preserving snake_case support
  • narrow TargetDefinition so the public input type matches the new runtime contract
  • update CLI schema and fallback-target tests to assert rejection semantics

Why

#935 deprecated camelCase aliases but intentionally kept them working. This change completes that migration by enforcing snake_case-only target config.

Verification

  • bun test packages/core/test/evaluation/providers/targets.test.ts packages/core/test/evaluation/providers/cli-schema.test.ts packages/core/test/evaluation/validation/targets-validator.test.ts
  • live provider smoke via AgentV resolver/provider path with snake_case target definitions:
    • azure -> returned OK
    • claude-cli -> returned OK
    • copilot-cli -> returned OK
  • note: local pre-push hook lint was flaky in this worktree and appeared to read the primary checkout's targets.ts; bun run lint passed in the branch worktree before push

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 5, 2026

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a0376b
Status: ✅  Deploy successful!
Preview URL: https://b7aa800a.agentv.pages.dev
Branch Preview URL: https://fix-azure-remove-camelcase-a.agentv.pages.dev

View logs

@christso christso marked this pull request as ready for review April 5, 2026 03:40
@christso christso merged commit 47080bb into main Apr 5, 2026
4 checks passed
@christso christso deleted the fix/azure-remove-camelcase-aliases branch April 5, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant