fix(stats): include execution errors in pass/total denominator#999
Merged
fix(stats): include execution errors in pass/total denominator#999
Conversation
Previously the summary showed passedCount/gradedCount where gradedCount excluded execution errors, making results appear better than they were. Now shows passedCount/total to match the Convex Evals convention that inspired this design: the denominator is all tests actually attempted, not just those that reached the grading stage. Execution errors are still reported separately in the detail section. Closes #998
Deploying agentv with
|
| Latest commit: |
9f99201
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://843cfe2a.agentv.pages.dev |
| Branch Preview URL: | https://fix-998-stat-denominator.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X / Ystat in the final eval summary frompassedCount / gradedCounttopassedCount / totalgradedCountpreviously excluded execution errors, making results look better than they wereBefore / After
Before: 2 of 23 tests crash before grading →
RESULT: PASS (7/21 scored >= 0.8, mean: 0.900)After:
RESULT: PASS (7/23 scored >= 0.8, mean: 0.900)Execution errors are still reported separately in the detail section — they just no longer disappear from the fraction.
Test plan
Closes #998