Merged
Conversation
Phase 0-1: Add SAFETY comments to intentional unsafe patterns, replace suppression comments with structured justifications. Phase 2-3: Harden CI (pin actions by SHA, add Clippy/rustfmt checks), update documentation and consolidate duplicated code in sparse Jacobian reverse-mode and bytecode forward pass. Phase 4: Decompose stde.rs (1409 lines) into 9-file directory module, bulk-add #[must_use] to 65 pure functions, and document GPU u32 cast assumptions.
gvonness-apolitical
force-pushed
the
cleanup/phase-0-4
branch
from
2fc071b to
9cbf268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stde.rs(1409 lines) into 9-file directory module, bulk-add#[must_use]to 65 pure functions across 9 files, document GPUu32cast assumptionsTest plan
cargo build --features bytecode,taylor,stde,parallel,diffopcargo test --features bytecode,taylor,stde,parallel,diffop— all 122 tests passcargo clippy --features bytecode,taylor,stde,parallel,diffop -- -D warnings— cleancargo clippy -- -W clippy::must_use_candidate— 0 warnings remainingcrate::stde::EstimatorResultresolves for GPU module)