Implementation of simba traits for DualVec#38
Open
afossa wants to merge 1 commit intoEntrolution:mainfrom
Open
Implementation of simba traits for DualVec#38afossa wants to merge 1 commit intoEntrolution:mainfrom
afossa wants to merge 1 commit intoEntrolution:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented simba traits in
simba_impls.rsforDualVec<F, N>. This allows to useDualVec<F, N>as scalar type in nalgebra matrices.Changes
SimdValue,PrimitiveSimdValue,SubsetOf,AbsDiffEq,RelativeEq,UlpsEq,Field,ComplexField,RealFieldforDualVec<F, N>. Implementations are modeled after those forDual<F>, e.g. comparisons are based on the real part of the dual number.Test Plan
nalgebra_integrations.rs.Checklist
cargo test)cargo clippy -- -D warnings)cargo fmt --check)