Skip to content

fix: always apply SSO token on public site, overriding stale session #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AshrafHosam merged 1 commit into from
Jun 24, 2026
Merged

fix: always apply SSO token on public site, overriding stale session #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions frontend/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ import { api } from './services/api.js'
onMounted(async () => {
const params = new URLSearchParams(window.location.search)
const ssoToken = params.get('sso_token')
if (!ssoToken || localStorage.getItem('access_token')) return

if (!ssoToken) return
// Always override stale session — new SSO token takes precedence
window.dispatchEvent(new Event('auth:logout'))
localStorage.removeItem('access_token')
localStorage.removeItem('refresh_token')
localStorage.removeItem('user')
localStorage.setItem('access_token', ssoToken)
try {
const res = await api.get('/api/auth/me')
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/composables/useAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const _token = ref(localStorage.getItem('access_token') ?? null)
const _isLoggedIn = computed(() => !!_user.value)

window.addEventListener('auth:logout', () => { _user.value = null; _token.value = null })
window.addEventListener('auth:login', (e) => { _user.value = e.detail })
window.addEventListener('auth:login', (e) => { _user.value = e.detail; _token.value = localStorage.getItem('access_token') ?? null })

function _persist(data) {
localStorage.setItem('access_token', data.tokens.access_token)
Expand Down
Loading