Skip to content

add diff rules for stablehlo.triangular_solve#2436

Draft
mofeing wants to merge 9 commits into
mainfrom
ss/diff-triangular_solve
Draft

add diff rules for stablehlo.triangular_solve#2436
mofeing wants to merge 9 commits into
mainfrom
ss/diff-triangular_solve

Conversation

@mofeing
Copy link
Copy Markdown
Collaborator

@mofeing mofeing commented Apr 16, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.47%. Comparing base (9b51369) to head (328230e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2436   +/-   ##
=======================================
  Coverage   25.47%   25.47%           
=======================================
  Files         220      220           
  Lines       44600    44600           
=======================================
  Hits        11364    11364           
  Misses      33236    33236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mofeing
Copy link
Copy Markdown
Collaborator Author

mofeing commented Apr 29, 2026

UPDATE: the diff rules require an update. they are wrong depending on the combination of lower, leftSide, unitDiagonal and transpose_a.

But openxla/stablehlo#2943 should help definitely to test all combinations correctly.

@mofeing mofeing force-pushed the ss/diff-triangular_solve branch from e1d2e14 to 328230e Compare May 11, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant