Binomial checkpointing#2485
Open
Pangoraw wants to merge 31 commits into
Open
Conversation
This was referenced May 15, 2026
wsmoses
reviewed
May 15, 2026
wsmoses
reviewed
May 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
+ Coverage 25.59% 25.67% +0.08%
==========================================
Files 221 221
Lines 44707 44796 +89
==========================================
+ Hits 11443 11502 +59
- Misses 33264 33294 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wsmoses
approved these changes
May 15, 2026
Member
wsmoses
left a comment
wsmoses
left a comment
There was a problem hiding this comment.
didn't investigate super deeply, but at a high level all looks good to me
Member
|
please fix the tests before merge though |
Member
|
and yeah we shuold support the non constant iter counts, iv tests, etc |
can do better than truly dynamic cache removal using dynamic pad
Collaborator
Author
|
cc @avik-pal if you can review the WhileLoopInfo changes |
avik-pal
approved these changes
Jun 6, 2026
Collaborator
avik-pal
left a comment
avik-pal
left a comment
There was a problem hiding this comment.
Checked on the WhileLoopInfo changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aka AD on a tight budget.