Skip to content

fix call to cusolver_gesvd#2494

Open
mofeing wants to merge 4 commits into
mainfrom
ss/fix-cuda-gesvd
Open

fix call to cusolver_gesvd#2494
mofeing wants to merge 4 commits into
mainfrom
ss/fix-cuda-gesvd

Conversation

@mofeing
Copy link
Copy Markdown
Collaborator

@mofeing mofeing commented May 16, 2026

for a m x n matrix where m < n, i run into the following error:

error copying to host: INVALID_ARGUMENT: The GPU implementation of gesvd requires that the input matrix be m x n with m >= n

this PR applies transposes to the input and outputs to work on n x m matrix in such case.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.47%. Comparing base (5dcaeea) to head (73551c8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2494   +/-   ##
=======================================
  Coverage   25.47%   25.47%           
=======================================
  Files         220      220           
  Lines       44609    44609           
=======================================
  Hits        11366    11366           
  Misses      33243    33243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wsmoses wsmoses requested a review from avik-pal May 17, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant