Added check on tessera calls for no capture#2513
Draft
jessicacotturone21 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
=======================================
Coverage 25.10% 25.10%
=======================================
Files 221 221
Lines 44682 44682
=======================================
Hits 11218 11218
Misses 33464 33464 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wsmoses
reviewed
May 27, 2026
| if (calleeAttr) { | ||
| auto callee = SymbolTable::lookupSymbolIn( | ||
| callOp->getParentOfType<ModuleOp>(), calleeAttr); | ||
| auto defineOp = dyn_cast_or_null<tessera::DefineOp>(callee); |
Member
There was a problem hiding this comment.
functionopinterface [and then it applies to all fns]
wsmoses
reviewed
May 27, 2026
| int offset = 0; | ||
| if (defineOp.getNumArguments() > 0 && | ||
| defineOp.getArgAttr(0, LLVM::LLVMDialect::getStructRetAttrName())) | ||
| offset = 1; |
Member
There was a problem hiding this comment.
this shouldn't be here if using function op interface [but the getArgAttr for defineOp should do the indexing change]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.