mlir: run mincut for scf.if ops#2846
Conversation
wsmoses
left a comment
There was a problem hiding this comment.
lgtm, but can we also do this for affineif as well?
Pangoraw
left a comment
There was a problem hiding this comment.
lgtm! we could potentially run mincut for every pairs of forward / reverse blocks as present in gutils->mapReverseModeBlocks (though nested ops don't populate the map rn)
|
@pengmai we have a conflict here rn if you can take a quick look [then we can merge, and address affine.if in follow ups] |
Done. FYI it looks like we don't currently support differentiation of affine.if at all, but these changes are templated in an
This would be interesting. We'd need to make sure it respects the |
No description provided.