lore-server: Enforce repository write permissions#49
Open
s-zaizen wants to merge 1 commit into
Open
Conversation
Require explicit write, admin, or owner repository permissions before mutation paths across gRPC, HTTP, protocol storage, and QUIC. Keep read authorization requiring read-like permissions so empty resource claims cannot grant access. Signed-off-by: s-zaizen <s@zaizen.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces repository permission claims for authorization and write paths in lore-server.
Repository authorization now requires a matching repository resource to include a read-like permission, and repository mutation paths require
write,admin,owner.Details
Repository authorization was based on whether a token contained a matching repository resource, but missing or empty permission lists were still treated as authorized. This allowed resource claims without repository permissions to pass authorization checks.
This updates the shared JWT authorization helpers and applies write checks across
Testing