Fix broken log#62
Open
metakunt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Meta Kunt <zugvzuzuguih@eclipso.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the log level is not being set to anything but debug, also you have a bit of duplications.
configure calls initialize but you call initialize in client_main, a redundant call.
Also the trace_log feature gives the compiler a bunch of warnings when you want to trace in lore-client. It seems that there is quite a bit of mess going on. For example lore_repository reexports the same bindings in lore_base to import from them instead of lore_base, there is a separate tracing crate used in lore_server that uses the same macro but from tracing instead.