fixing public ip stomping in windows batch script.#780
Merged
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom Feb 3, 2026
Merged
fixing public ip stomping in windows batch script.#780mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
Conversation
|
Collaborator
Author
|
fixes #768 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
(cherry picked from commit f288581)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
(cherry picked from commit f288581)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Feb 3, 2026
mcottontensor
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
When supplying --publicip on the windows batch scripts it was getting overridden.
Solution
The SetPublicIP step now checks that no ip has been previously specified.