fix: improve connection timeout handling for stale peers#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability and efficiency of the peer publishing mechanism in
src/Site/Site.pyby making peer connection freshness a key factor in both connection handling and peer selection. The main changes focus on detecting stale connections earlier and prioritizing peers with active connections, which should reduce failed publish attempts and improve network responsiveness.Peer connection handling improvements:
publishermethod to detect and close stale peer connections before attempting to publish, ensuring that only fresh and active sockets are used for publishing. If a connection is stale or missing, it is closed and a longer timeout is budgeted to allow for a full reconnect.Peer selection improvements:
publishmethod to sort peers by connection freshness, so that peers with the most recent activity are prioritized for publishing. This increases the likelihood of successful publishes and reduces noise from failed attempts due to stale connections.