fix: spawn download in background for immediate return and user feedback#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to both the backend and frontend to enhance user experience and code efficiency. The backend now spawns the site download process in the background, ensuring that the UI remains responsive and displays progress feedback to the user. On the frontend, minor CSS adjustments have been made to streamline the transform property for better maintainability.
Backend improvements:
addmethod inSiteManager.pynow spawns thesite.downloadprocess in the background usinggevent.spawn, allowing the UI to show a loading screen and progress bar without waiting for the download to finish.Frontend/CSS adjustments:
scaleX(0)andtranslate3d(0, 0, 0)transforms into a singletransformproperty inWrapper.cssfor cleaner and more maintainable code.