Fix DateTime Format with SystemTime#102
Merged
EricZimmerman merged 1 commit intoEricZimmerman:masterfrom Aug 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I committed #65 I did not implement the DateTime Formatting bit like the other BinConvert formats. This fixes the issue as the following happened depending on the region/ date time format set by the computer. This fix makes the behaviour consistent regardless of these settings. This is clean-up prep to adding more BinConvert formats.
US Region:
UK Region:
Fixed:
Checklist:
Please replace every instance of
[ ]with[X]OR click on the checkboxes after you submit your PR- [ ] I have generated a uniqueGUIDfor my Batch file(s)- [ ] I have tested and validated the new Batch file(s) against test data and achieved the desired output- [ ] I have placed the Batch file(s) within the.\RECmd\BatchExamplesdirectory- [ ] I have set or updated the version of my Batch file(s)- [ ] I have made an attempt to document the artifacts within the Batch file(s)- [ ] I have consulted the Guide/Template to ensure my Map(s) follow the same formatThank you for your submission and for contributing to the DFIR community!