Fixes sd and ss arguments and various other fixes#114
Merged
EricZimmerman merged 1 commit intoEricZimmerman:masterfrom May 4, 2026
Merged
Fixes sd and ss arguments and various other fixes#114EricZimmerman merged 1 commit intoEricZimmerman:masterfrom
EricZimmerman merged 1 commit intoEricZimmerman:masterfrom
Conversation
Owner
|
updated and deployed |
Owner
|
Too late slow poke |
Collaborator
|
You can tell where I got distracted in the whole repo/PR administration process :) |
Contributor
Author
|
I noticed that the recover flag is set to true by default now just for visibility. I don't see any problems with this but will let you both confirm you are happy with that change. @EricZimmerman @AndrewRathbun Old Code: new Option<bool>(
"--recover",
() => false,
"If true, recover deleted keys/values"),New Code: var recoverOpt = new Option<bool>("--recover")
{
Description = "If true, recover deleted keys/values. Default is true",
DefaultValueFactory = _ => true
}; |
Owner
|
Yea I did that, seeing as how it's default in re proper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes --sd and --ss which accidentally had --minSize as arguments. Also fixes the description of sync which had bits of the deduplicate description. Also adds new HelpAction to -f since -d had it added already.