Skip to content

Fixes sd and ss arguments and various other fixes#114

Merged
EricZimmerman merged 1 commit intoEricZimmerman:masterfrom
reece394:master
May 4, 2026
Merged

Fixes sd and ss arguments and various other fixes#114
EricZimmerman merged 1 commit intoEricZimmerman:masterfrom
reece394:master

Conversation

@reece394
Copy link
Copy Markdown
Contributor

@reece394 reece394 commented May 4, 2026

Fixes --sd and --ss which accidentally had --minSize as arguments. Also fixes the description of sync which had bits of the deduplicate description. Also adds new HelpAction to -f since -d had it added already.

@AndrewRathbun AndrewRathbun self-assigned this May 4, 2026
@EricZimmerman EricZimmerman merged commit bcd0ac3 into EricZimmerman:master May 4, 2026
1 check passed
@EricZimmerman
Copy link
Copy Markdown
Owner

updated and deployed

@EricZimmerman
Copy link
Copy Markdown
Owner

Too late slow poke

@AndrewRathbun
Copy link
Copy Markdown
Collaborator

You can tell where I got distracted in the whole repo/PR administration process :)

@reece394
Copy link
Copy Markdown
Contributor Author

reece394 commented May 4, 2026

I noticed that the recover flag is set to true by default now just for visibility. I don't see any problems with this but will let you both confirm you are happy with that change. @EricZimmerman @AndrewRathbun

Old Code:

new Option<bool>(
                "--recover",
                () => false,
                "If true, recover deleted keys/values"),

New Code:

        var recoverOpt = new Option<bool>("--recover")
        {
            Description = "If true, recover deleted keys/values. Default is true",
            DefaultValueFactory = _ => true
        };

@EricZimmerman
Copy link
Copy Markdown
Owner

Yea I did that, seeing as how it's default in re proper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants