Update API base URL to support non-localhost scenarios.#12
Merged
Conversation
Owner
|
perfect, I think that makes sense. regarding the formatting: no problem, we can leave it like that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR simply updates how the base URL is calculated to allow for running
fazein a way where it's not accessed vialocalhost.A small note: the change is smaller than my diff here, but my editor just went and auto-reformatted some of the code. I don't know if you care about this or not. If you do care about this, just say the word and I'll unwind all the formatting changes.