Skip to content

Audit project against Rust best practices#13

Closed
ErickJ3 wants to merge 8 commits into
mainfrom
chore/rust-best-practices-audit
Closed

Audit project against Rust best practices#13
ErickJ3 wants to merge 8 commits into
mainfrom
chore/rust-best-practices-audit

Conversation

@ErickJ3
Copy link
Copy Markdown
Owner

@ErickJ3 ErickJ3 commented May 26, 2026

Audit of the workspace against Apollo's Rust best practices handbook plus targeted fixes for the issues found. Covers panic removal in production paths (ui.rs, storage Mutex locks, CLI path handling), a real bug where format!("{:?}", enum) was persisted to SQLite but parse_severity_level only matched 6 of 25 SeverityLevel variants, batched storage inserts under a single transaction, hex encoding via lookup table, removal of redundant clones, inheritance of the workspace [lints] block (previously dead config), and module/crate documentation.

Clippy warnings drop from 743 to 584, all 126 tests pass, release build clean.

Verified:

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets --locked
  • cargo test --workspace --locked
  • cargo build --workspace --release --locked

@ErickJ3 ErickJ3 closed this May 26, 2026
@ErickJ3 ErickJ3 deleted the chore/rust-best-practices-audit branch May 26, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant