Improvement docs and more#14
Merged
Merged
Conversation
ErickJ3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit of the workspace against Apollo's Rust best practices handbook plus targeted fixes for the issues found. Covers panic removal in production paths (
ui.rs, storageMutexlocks, CLI path handling), a real bug whereformat!("{:?}", enum)was persisted to SQLite butparse_severity_levelonly matched 6 of 25SeverityLevelvariants, batched storage inserts under a single transaction, hex encoding via lookup table, removal of redundant clones, inheritance of the workspace[lints]block (previously dead config), and module/crate documentation.