fix: fold codex tool calls in chat#9
Open
Franklin-Zhang0 wants to merge 1 commit intoEriconaldo:mainfrom
Open
Conversation
Owner
|
These changes (collapsible codex tool messages, legacy content fallback, and structured toolInput/toolResult storage) seem to have already been merged as part of #8 — that PR included the same getToolMessageDetails function, the legacy content parsing logic, and the structured field storage in handleCodexMessage. Can you double check and if confirmed can close this PR? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content, so existing sessions also render as foldable tool messagestoolInputandtoolResultfields so new sessions render consistentlyTesting
cd server && npm test -- AgentManager.codexTools.test.tscd client && npm test -- AgentChat.test.ts