Option to send corrections by alconesp · Pull Request #44 · Eseperio/verifactu-php

alconesp · 2025-11-26T20:58:26Z

Updates done:

New property to mark an InvoiceSubmission as a correction
The InvoiceSerializer is able to include the "Subsanacion" node
Example on how to use the new property for corrections

…tions

…operty

Copilot

Pull request overview

Adds support for marking an InvoiceSubmission as a correction so the generated XML can include the Subsanacion element, with corresponding test and documentation updates.

Changes:

Add InvoiceSubmission::$isCorrection (validated as YesNoType|null).
Update InvoiceSerializer::toInvoiceXml() to optionally emit the sf:Subsanacion node.
Extend unit tests and README example to cover correction/subsanacion usage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`src/models/InvoiceSubmission.php`	Adds the new `isCorrection` property and validation rule.
`src/services/InvoiceSerializer.php`	Emits `sf:Subsanacion` based on the new property.
`tests/Unit/Services/InvoiceSerializerTest.php`	Adds/adjusts XML assertions and introduces a new correction-related test case.
`tests/Unit/Models/InvoiceSubmissionTest.php`	Populates the new property in an existing test setup.
`README.md`	Documents how to use the new property in the usage example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T18:26:04Z

 use eseperio\verifactu\models\Breakdown;
 use eseperio\verifactu\models\BreakdownDetail;
 use eseperio\verifactu\models\ComputerSystem;
+use eseperio\verifactu\models\enums\YesNoType;


The YesNoType import is unused in this file, which will be flagged by static analysis/linters. It can be removed unless you plan to reference the enum directly (e.g., for YesNoType::YES comparisons).

Suggested change

use eseperio\verifactu\models\enums\YesNoType;

Copilot · 2026-03-30T18:26:05Z

+        // Verify subsanation is not present
+        $correction = $dom->getElementsByTagNameNS(InvoiceSerializer::SF_NAMESPACE, 'Subsanacion');


The comment says “Subsanacion is not present”, but the assertion dereferences item(0) and checks for NO, which implies the node is present. Either assert $correction->length === 0 (if it should be omitted) or assert length === 1 and update the comment to reflect that it defaults to NO.

Suggested change

// Verify subsanation is not present

$correction = $dom->getElementsByTagNameNS(InvoiceSerializer::SF_NAMESPACE, 'Subsanacion');

// Verify subsanation element is present and defaults to NO

$correction = $dom->getElementsByTagNameNS(InvoiceSerializer::SF_NAMESPACE, 'Subsanacion');

$this->assertEquals(1, $correction->length);

Copilot · 2026-03-30T18:26:05Z

+$invoice->invoiceWithoutRecipient = YesNoType::NO;
+
+// If providing a subsanation after receiving an "Accepted with error" message
+// $invoice->isCorrection = true;


The README example sets isCorrection to a boolean (true), but the model expects a YesNoType (and validation enforces that). Update the example to use YesNoType::YES (and optionally show null/unset for the default).

Suggested change

// $invoice->isCorrection = true;

// Default is null (no correction). To mark this invoice as a correction use:

// $invoice->isCorrection = YesNoType::YES;

Copilot · 2026-03-30T18:26:05Z

+    /**
+     * Test that the InvoiceSerializer can generate a XML for InvoiceSubmission with the subsanation info
+     */
+    public function testToInvoiceXmlWithIsSubsanation()
+    {
+         // Create a basic InvoiceSubmission object
+        $invoice = $this->createBasicInvoiceSubmission();
+        $invoice->isCorrection = YesNoType::YES;
+
+        // Generate XML using the serializer
+        $dom = InvoiceSerializer::toInvoiceXml($invoice, false); // Skip validation
+
+        // Verify subsanation is present
+        $subsanation = $dom->getElementsByTagNameNS(InvoiceSerializer::SF_NAMESPACE, 'Subsanacion');
+        $this->assertEquals(YesNoType::YES->value, $subsanation->item(0)->textContent);
+    }


This test method is inconsistent with the rest of the file: it lacks a : void return type, doesn’t assert the NodeList length before reading item(0), and the name/comment use “Subsanation” while the XML element is Subsanacion. Align the naming, add : void, and assert $subsanation->length === 1 before reading item(0) to avoid null dereferences.

Copilot · 2026-03-30T18:26:06Z

+    /**
+     * Identifies if a submission is to subsanate a previous one accepted with errors
+     *
+     * @var YesNoType|null
+     */
+    public $isCorrection;


Docblock wording “subsanate” is incorrect/unclear English. Consider rephrasing to something like “Indicates whether this submission corrects a previous one accepted with errors” (and keep terminology consistent with the XML element name Subsanacion).

Copilot · 2026-03-30T18:26:06Z

+		// Subsanacion (optional)
+		if($invoice->isCorrection) {
+			$root->appendChild($doc->createElementNS(self::SF_NAMESPACE, 'sf:Subsanacion', (string) $invoice->isCorrection->value));
+		}


This block uses tabs and is missing spaces after if/before {, which is inconsistent with the surrounding style in this file (spaces indentation + if (...) {). Reformat to match the existing code style to keep diffs consistent and avoid formatter churn.

Suggested change

// Subsanacion (optional)

if($invoice->isCorrection) {

$root->appendChild($doc->createElementNS(self::SF_NAMESPACE, 'sf:Subsanacion', (string) $invoice->isCorrection->value));

}

// Subsanacion (optional)

if ($invoice->isCorrection) {

$root->appendChild($doc->createElementNS(self::SF_NAMESPACE, 'sf:Subsanacion', (string) $invoice->isCorrection->value));

}

Copilot · 2026-03-30T18:26:06Z

        $invoice->operationDescription = 'Test operation';
        $invoice->taxAmount = 21.00;
        $invoice->totalAmount = 121.00;
+        $invoice->isCorrection = YesNoType::NO;


createBasicInvoiceSubmission() now always sets $invoice->isCorrection = YesNoType::NO;. If the intention is that Subsanacion is optional and omitted unless explicitly requested, this should be left as null here so the “default invoice” path doesn’t force emission of the node.

Suggested change

$invoice->isCorrection = YesNoType::NO;

Copilot · 2026-03-30T18:26:07Z

+		// Subsanacion (optional)
+		if($invoice->isCorrection) {
+			$root->appendChild($doc->createElementNS(self::SF_NAMESPACE, 'sf:Subsanacion', (string) $invoice->isCorrection->value));
+		}


if ($invoice->isCorrection) is effectively a null-check because YesNoType::NO is still truthy (it’s an enum object). That means Subsanacion will be emitted for both YES and NO whenever the property is set, which may not match the intended “only send for corrections” behavior. Make the intent explicit by checking !== null (emit both YES/NO) or comparing to YesNoType::YES (emit only for corrections).

Suggested change

// Subsanacion (optional)

if($invoice->isCorrection) {

$root->appendChild($doc->createElementNS(self::SF_NAMESPACE, 'sf:Subsanacion', (string) $invoice->isCorrection->value));

}

// Subsanacion (optional)

if ($invoice->isCorrection === YesNoType::YES) {

$root->appendChild($doc->createElementNS(self::SF_NAMESPACE, 'sf:Subsanacion', (string) $invoice->isCorrection->value));

}

alconesp added 3 commits November 26, 2025 21:54

UPDATE Invoice submission process to include an option to send correc…

04cedea

…tions

UPDATE Readme file to use the prover value for corrections

d85ec3c

UPDATE InvoiceSubmission to use YesNoType for the new isCorrection pr…

3c7edd4

…operty

juanluislopez89 mentioned this pull request Nov 27, 2025

¿El registro de facturacion con el hash cuándo debe generarse? #43

Closed

Eseperio requested a review from Copilot March 30, 2026 18:21

Copilot started reviewing on behalf of Eseperio March 30, 2026 18:22 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

abrahampo1 approved these changes Mar 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to send corrections#44

Option to send corrections#44
alconesp wants to merge 3 commits into
Eseperio:masterfrom
alconesp:feature/ability-to-send-corrections

alconesp commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// Verify subsanation is not present
		$correction = $dom->getElementsByTagNameNS(InvoiceSerializer::SF_NAMESPACE, 'Subsanacion');

	// $invoice->isCorrection = true;
	// Default is null (no correction). To mark this invoice as a correction use:
	// $invoice->isCorrection = YesNoType::YES;

Conversation

alconesp commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants