Open
Conversation
EshaanAgg
requested changes
Dec 12, 2023
Owner
EshaanAgg
left a comment
EshaanAgg
left a comment
There was a problem hiding this comment.
Please address the commented changes. The PR as a whole looks good, but I would love it if you can try to improve the paragraph's style a bit more. You can use CodePen as a reference.
src/pages/about.astro
Outdated
| from our collective commitment to advancing excellence in the realm | ||
| of Open Source. We, members of | ||
| <div class="flex items-center justify-center"> | ||
| <Image class="h-[4rem] w-fit" src={COPSLogo} alt="" /> Club Of |
Owner
There was a problem hiding this comment.
Do not use images in line with text. It is bad for accessibility.
Contributor
Author
There was a problem hiding this comment.
Should I remove the logo from that place and Just bold the COPS-IITBHU instead?
here is the updated UI
Contributor
Author
There was a problem hiding this comment.
How should I use Codepen for reference , please elaborate a little , and also about the paragraph styling , how would you like it to be, a bit more scattered or more condensed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added About us page and did required changes #30
CopsAboutUs1.mp4