Fix/domain get context fix#9
Open
PieterPaulussen wants to merge 2 commits into
Open
Conversation
PieterPaulussen
commented
May 24, 2018
Author
There was a problem hiding this comment.
@StefanRijnhart the context value is also missing here and here. Do you want me to fix these as well?
PieterPaulussen
force-pushed
the
fix/domain_get_context_fix
branch
from
370063c to
2f49102
Compare
Collaborator
There was a problem hiding this comment.
Maybe better to just expand the signature to the standard signature for old API function fields: function(self, cr, uid, ids, field, arg, context=None)
Author
There was a problem hiding this comment.
Great, thanks for the tip. That is indeed the cleanest way to do it.
PieterPaulussen
force-pushed
the
fix/domain_get_context_fix
branch
from
2f49102 to
38ac1bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 things: