Skip to content

fix: combine release-please and publish into single workflow#7

Merged
matmilbury merged 1 commit into
mainfrom
fix/release-workflow
Apr 27, 2026
Merged

fix: combine release-please and publish into single workflow#7
matmilbury merged 1 commit into
mainfrom
fix/release-workflow

Conversation

@matmilbury
Copy link
Copy Markdown
Contributor

Summary

The release pipeline was broken: release-please.yml created GitHub Releases and tags using GITHUB_TOKEN, but GitHub Actions does not trigger on: push: tags workflows from GITHUB_TOKEN-created events (to prevent infinite loops). This meant release.yml (npm publish) never ran — v0.2.2 and v0.3.0 were never published to npm.

Combines both workflows into a single release.yml following the pattern used in openclaw-plugin:

  • release-please job runs on push to main, outputs releases_created
  • publish job gates on that output and runs npm publish
  • workflow_dispatch allows manual publish (useful for recovering v0.3.0)

Type

  • Bug fix

Changes

  • .github/workflows/release.yml: merged release-please + publish into single workflow
  • .github/workflows/release-please.yml: deleted (redundant)

Checklist

  • No secrets or credentials committed
  • No breaking changes

QA Instructions

  1. Merge this PR
  2. Run workflow_dispatch on the Release workflow to publish v0.3.0
  3. Verify npm view @eterna-hybrid-exchange/cli versions includes 0.3.0
  4. Future merges of release-please PRs should auto-publish

The separate release-please.yml created tags via GITHUB_TOKEN, which
does not trigger downstream on-tag workflows (GitHub Actions limitation).
This meant release.yml never ran for v0.2.2 or v0.3.0, so npm publish
never happened.

Merge both into release.yml following the openclaw-plugin pattern:
release-please runs first, then publish gates on releases_created output.
Also adds workflow_dispatch to manually trigger publishes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matmilbury matmilbury merged commit 5df98c3 into main Apr 27, 2026
1 check passed
@matmilbury matmilbury deleted the fix/release-workflow branch April 27, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant