feat: raise maxDownloadBytes and inputLimits to 500MB, add runtime env vars (#210)#237
Open
chrip wants to merge 3 commits into
Open
feat: raise maxDownloadBytes and inputLimits to 500MB, add runtime env vars (#210)#237chrip wants to merge 3 commits into
chrip wants to merge 3 commits into
Conversation
Server submodule (e4153f8) raises FileConverter.converter.maxDownloadBytes from 100MB to 500MB and every inputLimits uncompressed zip size to 500MB in Common/config/default.json. These are the new built-in defaults that the docker-entrypoint env overrides build on (#210). Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com> Assisted-by: ClaudeCode:claude-sonnet-4-6
…210) Add two runtime overrides to the generated NODE_CONFIG in docker-entrypoint.sh so the max upload/conversion size can be tuned without mounting local.json (which is regenerated on every start): - FILECONVERTER_MAX_DOWNLOAD_BYTES (default 500MB) - FILECONVERTER_INPUT_LIMIT_UNCOMPRESSED (default 500MB) The interpolated values must break out of the single-quoted NODE_CONFIG string ('${VAR:-default}') to be expanded by the shell; otherwise the literal ${VAR} is written into the JSON and breaks config parsing at startup. Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com> Assisted-by: ClaudeCode:claude-sonnet-4-6
The standalone image runs build/scripts/standalone/entrypoint.sh (not the orchestrated entrypoint). The FileConverter env var support added in the orchestrated script was absent here. Add FILECONVERTER_MAX_DOWNLOAD_BYTES and FILECONVERTER_INPUT_LIMIT_UNCOMPRESSED with the same jq_set pattern used by every other configurable setting in this script. When set, FILECONVERTER_MAX_DOWNLOAD_BYTES replaces maxDownloadBytes (must be a plain byte count; non-numeric values are warned and skipped). When set, FILECONVERTER_INPUT_LIMIT_UNCOMPRESSED replaces the uncompressed limit for all four zip-based formats (docx, xlsx, pptx, vsdx). When unset, the built-in default.json values apply (500 MB each). Assisted-by: ClaudeCode:claude-sonnet-4-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #210. Companion server-side PR: Euro-Office/server#35 — both PRs must be merged together.
What changes
serversubmodule (Euro-Office/server#35)Bumps the built-in defaults in
Common/config/default.json:maxDownloadBytes: 100 MB → 500 MBinputLimitsuncompressed zip sizes: 50 MB / 300 MB → 500 MBbuild/scripts/orchestrated/docker-entrypoint.shFixes a single-quote escaping bug that caused env vars inside
NODE_CONFIG='...'to be emitted literally (invalid JSON, silently ignored). Adds two runtime overrides:FILECONVERTER_MAX_DOWNLOAD_BYTES— max file download size in bytes (default 500 MB)FILECONVERTER_INPUT_LIMIT_UNCOMPRESSED— max uncompressed zip size for docx/xlsx/pptx/vsdx (default 500 MB)build/scripts/standalone/entrypoint.shAdds the same two env vars for the standalone (single-container) image, using the existing
jq_setpattern. Without this the env vars were silently ignored in standalone deployments.Testing
Verified with a 144 MB synthetic
.docxfile (incompressible random-noise PNGs):FILECONVERTER_MAX_DOWNLOAD_BYTES=10485760(10 MB) causes the file to be rejected; removing it restores the 500 MB defaultAssisted-by: ClaudeCode:claude-sonnet-4-6