Skip to content

chore: replace short JWT_SECRET defaults with ≥32-char value #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrip wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: replace short JWT_SECRET defaults with ≥32-char value #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ We currently provide a docker image for testing and integration purposes. We are

```
docker pull ghcr.io/euro-office/documentserver:latest
docker run -i -t -d -p 8080:80 --restart=always -e EXAMPLE_ENABLED=true -e JWT_SECRET=my_jwt_secret ghcr.io/euro-office/documentserver:latest
docker run -i -t -d -p 8080:80 --restart=always -e EXAMPLE_ENABLED=true -e JWT_SECRET=my_long_jwt_secret_at_least_32_chars ghcr.io/euro-office/documentserver:latest
```

### Building
Expand Down
2 changes: 1 addition & 1 deletion build/scripts/orchestrated/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export NODE_CONFIG='{
},
"secret": {
"inbox": {
"string": "'${JWT_SECRET_INBOX:-${JWT_SECRET:=secret}}'"
"string": "'${JWT_SECRET_INBOX:-${JWT_SECRET:=euro-office-dev-jwt-secret-key-2026}}'"
},
"outbox": {
"string": "'${JWT_SECRET_OUTBOX:-${JWT_SECRET}}'"
Expand Down
2 changes: 1 addition & 1 deletion build/scripts/orchestrated/example-docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export NODE_CONFIG='{
"siteUrl": "'${DS_URL:-"/"}'",
"token": {
"enable": '${JWT_ENABLED:-false}',
"secret": "'${JWT_SECRET:-secret}'",
"secret": "'${JWT_SECRET:-euro-office-dev-jwt-secret-key-2026}'",
"authorizationHeader": "'${JWT_HEADER:-Authorization}'"
}
}
Expand Down
2 changes: 1 addition & 1 deletion document-server-integration
Open in desktop
Submodule document-server-integration updated 9 files
+3 −3 Readme.md
+1 −1 docker-compose.yml
+2 −2 web/documentserver-example/go/README.md
+1 −1 web/documentserver-example/go/config/configuration.json
+1 −1 web/documentserver-example/nodejs/docker-entrypoint.sh
+1 −1 web/documentserver-example/php-laravel/.env.example
+2 −2 web/documentserver-example/php/docker-compose.yml
+2 −2 web/documentserver-example/python/compose-base.yml
+2 −2 web/documentserver-example/ruby/compose-base.yml
Loading