feat: package build#8
Merged
Merged
Conversation
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
chrip
approved these changes
May 20, 2026
chrip
left a comment
chrip
left a comment
Contributor
There was a problem hiding this comment.
Tested end-to-end on arm64. Built the companion DocumentServer image, ran the container, and verified the example app at http://localhost:8082/example/.
Results:
- ✅ All 30 files across 8 frameworks (ASP.NET, Java, Node.js, Python, PHP, Laravel, Go, vanilla JS) correctly branded
Euro-Office - ✅ Page titles, welcome text, portal descriptions all updated
- ✅
favicon_eo.svgadded for Go and Node.js examples - ✅ Node.js config paths updated (
/var/lib/euro-office/) - ✅
EXAMPLE_URLenv var added to docker-entrypoint.sh - ✅ DOCX documents open and edit correctly in the integrated editor
The branding change is consistent across every example. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: Euro-Office/DocumentServer#92