Skip to content

Feat: rebrand, possibility for own brand#9

Merged
rikled merged 2 commits into
mainfrom
feat/rebrand
May 28, 2026
Merged

Feat: rebrand, possibility for own brand#9
rikled merged 2 commits into
mainfrom
feat/rebrand

Conversation

@rikled

@rikled rikled commented May 26, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
@rikled rikled marked this pull request as ready for review May 27, 2026 15:06
@juliusknorr juliusknorr moved this from 📄 To do to 👀 In review in 📄 Euro-Office team May 28, 2026

@chrip chrip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the integration layer rebranding. The appName config approach for the node example is clean, and the consistent color swap across all example apps (csharp, go, java, php, python, ruby) is thorough. Here are some observations:

Suggestions:

  1. example.bake.Dockerfilesed on config JSON (lines 32-33):
    sed -i "s/Euro-Office/${COMPANY_NAME}/g" on config files is fragile. If a config value legitimately contains "Euro-Office" as a non-branding string, it will be incorrectly replaced. Also, this only replaces Euro-Office (title case) — the config files I see in the diff use "Euro-Office" as the appName value, but the original diff also had "documentserver" references in other repos. Make sure the case-sensitive match is intentional and consistent with the other repos' branding approach.

  2. example.bake.DockerfileCOPY ${BRANDING_DIR}/document-server-integration/web/documentserver-example/nodejs /app (line 30):
    This overlays branding on top of the existing /app directory, which is the right approach (unlike the server repo which overwrites everything). However, if the branding dir doesn't include all files (e.g., missing app.js), the build will silently use the original files. Consider adding a check that critical branding files exist before the copy.

  3. mobile-logo.svgmobile-logo_eo.svg renameforgotten.ejs, index.ejs, wopiIndex.ejs:
    The logo file is renamed to mobile-logo_eo.svg but the original mobile-logo.svg is not removed. This leaves a dead file in the repo and could cause confusion. Also, the favicon_eo.svg reference in the views suggests a favicon rename that doesn't appear in the diff — is that in the branding dir?

  4. Hardcoded "Euro-Office" in all config filesdevelopment-linux.json, development-mac.json, development-windows.json, production-linux.json, production-windows.json:
    All configs now have "appName": "Euro-Office" hardcoded. For a rebranding PR, these should either be "DocumentServer" (upstream default) or removed entirely so the upstream default applies. Otherwise every developer or builder gets "Euro-Office" branding by default.

  5. editor.ejs — inline <%= appName %> in onMetaChange (line 98):
    document.title = event.data.title + " - <%= appName %>"; — this EJS template string is being passed to the client-side JS. The <%= appName %> will be rendered server-side during template compilation, so this works, but it's easy to miss that the template is being evaluated twice (once by EJS, once by the browser). Consider documenting this to avoid confusion.

  6. Color changes across 6 example apps — all #FF6F3D#0082C9:
    This is a lot of CSS changes across many example apps. While the blue color is consistent, consider whether each example app (csharp, go, java, php, python, ruby) should share a common stylesheet or if maintaining 6 separate CSS files long-term is sustainable.

Overall: Solid rebranding work. Once the hardcoded "Euro-Office" defaults are fixed to upstream values and the logo file situation is cleaned up, this is ready to merge.

@rikled rikled merged commit b3eebf3 into main May 28, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make package and image naming dynamic based on company name

3 participants