feat(cell): add Excel-style cell checkboxes#28
Draft
juliusknorr wants to merge 1 commit into
Draft
Conversation
Add a checkbox flag to the cell xf (model, binary serialization, history/ undo-redo), render boolean checkbox cells as a clickable glyph, toggle on click and Space, and expose asc_insertCheckbox which applies the format and sets blank cells to FALSE. AI-assistant: Claude Code 2.1.163 (claude-opus-4-8) Signed-off-by: Julius Knorr <jus@bitgrid.net>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Excel-style cell checkboxes to the spreadsheet SDK.
checkboxflag on the cell xf: model, binary serialization (c_oSerXfsTypes.Checkbox), history/undo-redo.asc_insertCheckboxapplies the format to the selection and sets blank cells to FALSE, in one history transaction.Verified live: checkbox cells render, click and Space toggle TRUE↔FALSE, undo works. Caught and fixed a crash where the draw path passes a Range (not a Cell) to the checkbox check — uses
getXfs(true)instead of the Cell-onlygetCompiledStyle().Note: independent/alternative implementation; an existing
feature/checkboxbranch also implements this. Opened for comparison.