Skip to content

feat: package build#21

Merged
rikled merged 3 commits into
mainfrom
feat/pkgbuild
May 26, 2026
Merged

feat: package build#21
rikled merged 3 commits into
mainfrom
feat/pkgbuild

Conversation

@rikled

@rikled rikled commented May 11, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
rikled added 2 commits May 11, 2026 19:15
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
@rikled rikled requested a review from juliusknorr May 12, 2026 21:23

@chrip chrip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. AdminPanel branding — favicon, logo, and dark-logo SVGs added. All three SVG files are missing trailing newlines (\ No newline at end of file). Consider adding them for consistency.

  2. HTML/JS title changes — "ONLYOFFICE" → "Euro-Office" in index.html, LoginPage.js, SetupPage.js, and Menu.js. alt text also updated. Looks correct.

  3. production-linux.json — all paths consistently changed from onlyoffice to euro-office across log, runtime, storage, wopi, services, license, and FileConverter sections. Thorough.

  4. Makefile — DOCUMENT_ROOT, OUTPUT, install paths all updated. One thing to note: line 147 still creates the onlyoffice user (useradd -m -d /var/www/onlyoffice -r -U onlyoffice). If the user should also be renamed to euro-office, this line needs updating. If not, consider adding a comment explaining why the user stays as onlyoffice while paths change.

@rikled

rikled commented May 26, 2026

Copy link
Copy Markdown
Member Author
4. **Makefile** — DOCUMENT_ROOT, OUTPUT, install paths all updated. One thing to note: line 147 still creates the `onlyoffice` user (`useradd -m -d /var/www/onlyoffice -r -U onlyoffice`). If the user should also be renamed to `euro-office`, this line needs updating. If not, consider adding a comment explaining why the user stays as `onlyoffice` while paths change.

Makefile is unused, so this is fine atm.

@rikled rikled merged commit 4d0caf4 into main May 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants