fix: gate document:ready on script:loaded in PDF editor#134
Open
Alex-Arsys wants to merge 1 commit into
Open
Conversation
Alex-Arsys
requested review from
emberfiend and
moodyjmz
and removed request for
a team
The 500ms setTimeout before triggering document:ready was a race
condition: postLaunchScripts (including the FormsTab view class) load
asynchronously after app:ready, but in dev mode 30+ individual files
consistently take longer than 500ms to load. When Toolbar.applyMode
called FormsTab.setConfig before PDFE.Views.FormsTab was defined,
createView received undefined as the view constructor, leaving
_viewsCache in an inconsistent state and triggering EditingError -25
("An error occurred during the work with the document").
After the 500ms minimum, check LaunchController.isScriptLoaded(). If
scripts are still loading, defer fireDocumentReady until script:loaded
fires — the same pattern already used throughout DocumentHolderExt,
LeftMenu and Toolbar in this editor.
Fixes #38
Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Alex Hernández <ahmartin@arsys.es>
Alex-Arsys
force-pushed
the
fix/error-editing-pdf-form
branch
from
73a24ef to
fa69283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 500ms setTimeout before triggering document:ready was a race condition: postLaunchScripts (including the FormsTab view class) load asynchronously after app:ready, but in dev mode 30+ individual files consistently take longer than 500ms to load. When Toolbar.applyMode called FormsTab.setConfig before PDFE.Views.FormsTab was defined, createView received undefined as the view constructor, leaving _viewsCache in an inconsistent state and triggering EditingError -25 ("An error occurred during the work with the document").
After the 500ms minimum, check LaunchController.isScriptLoaded(). If scripts are still loading, defer fireDocumentReady until script:loaded fires — the same pattern already used throughout DocumentHolderExt, LeftMenu and Toolbar in this editor.
Fixes #38
Assisted-by: ClaudeCode:claude-sonnet-4-6