🐛 fix(branding): remove ONLYOFFICE branding from loader and unlock customization (#89) — webpack mirror [PARKED]#140
Draft
moodyjmz wants to merge 4 commits into
Draft
Conversation
…ess cause; harden verify-bundles gate - docs/webpack-migration.md gotcha #8: expand SW staleness note to explain WHY incognito is required locally — PRODUCT_VERSION is pinned in the eo Makefile so local rebuilds emit app.js at the same URL with no cache_tag change; SW serves the stale bundle. Production deploys self-bust via the version-prefix redirect + flush-cache.sh. - docs/webpack-migration.md gotcha #9: add invariant note — output.clean:false is safe only because the output set is fixed. Enabling splitChunks, async import(), or asyncChunks without content-hashed filenames or per-editor cleaning leaves stale chunks on disk that the SW will cache silently. - build/webpack.editor.factory.mjs: matching inline comments at clean:false and splitChunks:false cross-referencing the invariant and the Common scoping finding, so the constraint is visible at the call site without needing to consult docs separately. - build/scripts/verify-bundles.mjs: hard-fail (not warn) when BUILD_ROOT exists but an expected bundle is absent. Previously warn-and-continue allowed a partial build to pass the token-survivor gate; each gate should be self-sufficient even though verify-deploy also checks bundle existence. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
CSS hashes in mobile index.html files updated to reflect esbuild output from the TerserPlugin → EsbuildPlugin switch. Build artifacts — no functional change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…ense (#89) Drop the asc_getCanBranding() license factor from canBrandingExt in all five editors so integrator branding works on the AGPL community build instead of raising the "paid feature" dialog. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Replace the ONLYOFFICE "romb" splash diamonds with the theme logo (light/dark via
the applied theme-type-dark class) and tokenize the static <title>. deploy-html.js now
substitutes {{APP_TITLE_TEXT}}, {{LOADER_LOGO}} and {{LOADER_LOGO_DARK}} from the theme
config, mirroring grunt's replace:indexhtml.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parked. Webpack mirror of #139 (which lands the same fix on the grunt
mainline). Same source edits as #139 —Main.jsgate unlock +.deployloader logo/title — with the build wiring expressed for webpack:deploy-html.jsnow substitutes{{APP_TITLE_TEXT}}/{{LOADER_LOGO}}/{{LOADER_LOGO_DARK}}(mirrors grunt'sreplace:indexhtml).Verified with
make web-apps-dev(incl. mobile): splash logo correct in light + dark, title branded.Held until the webpack migration lands; will be rebased/updated as the pipeline evolves. Docs (
theme/README.md) intentionally live on #139 only.🤖 Generated with Claude Code