fix(mobile): show copy/cut/paste icons in context actions#155
Open
n-goncalves wants to merge 1 commit into
Open
fix(mobile): show copy/cut/paste icons in context actions#155n-goncalves wants to merge 1 commit into
n-goncalves wants to merge 1 commit into
Conversation
Signed-off-by: n-goncalves <n-goncalves@users.noreply.github.com>
n-goncalves
requested review from
moodyjmz and
rikled
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the mobile editor, you can have access to contextual actions based on the selected element. For items that should be shown as icons, those icons aren't imported in the JSX code. That cause the icons to be missing in all editors.
Show screenshot of the missing icon in spreadsheeteditor
This PR fixes it. For now it is only testable in the fallback path since ContextAction is commented out, but it's simple enough to be merged as is.
Not providing a picture of it working due to Euro-Office/DocumentServer#258 but I have tested it.