fix: 🎨 Improve readability of long error messages in ErrorBoundary dialog#84
Open
wapec wants to merge 1 commit into
Open
fix: 🎨 Improve readability of long error messages in ErrorBoundary dialog#84wapec wants to merge 1 commit into
wapec wants to merge 1 commit into
Conversation
- white-space: pre-wrap for stack-trace newlines and indentation - -webkit-line-clamp increase from 7 to 12 for more context per dialog - drop redundant max-height Signed-off-by: Bohdan Baranov <wapec@icloud.com>
moodyjmz
reviewed
Jun 18, 2026
moodyjmz
left a comment
Member
There was a problem hiding this comment.
Two small follow-up items from the review:
| color: @text-error; | ||
| text-align: left; | ||
| overflow-wrap: break-word; | ||
| white-space: pre-wrap; |
Member
There was a problem hiding this comment.
A very long unbroken token (e.g. a minified URL in a stack frame) won't wrap at a word boundary with overflow-wrap: break-word alone — it only breaks at word boundaries. Adding word-break: break-all ensures any run of non-space characters is also wrapped.
Suggested change
| white-space: pre-wrap; | |
| overflow-wrap: break-word; | |
| word-break: break-all; |
| text-overflow: ellipsis; | ||
| max-height: 120px; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This rule is shared by all four mobile editors (documenteditor, spreadsheeteditor, presentationeditor, visioeditor). Worth ticking the checklist against each one before merging, not just the one used for the test script above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to trigger the dialog
Open any mobile editor, then in the editor iframe's DevTools console:
Before / after — last line clipping
Test checklist
…, not half-clipped