Fix channel ordering bug via bulk edit_channel_positions (Closes #30)#32
Closed
Krishnamkondekar wants to merge 1 commit into
Closed
Fix channel ordering bug via bulk edit_channel_positions (Closes #30)#32Krishnamkondekar wants to merge 1 commit into
Krishnamkondekar wants to merge 1 commit into
Conversation
Collaborator
|
Stop wasting our time with AI slop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause Analysis
The issue arises because the code currently attempts to synchronize positions via single, sequential API calls within ensure_text_channel (using channel.edit(position=position)).
On large configurations—such as the Sponsors category containing 17+ channels—firing these calls sequentially causes a massive race condition on Discord's backend. Since the operations are processed asynchronously, Discord recalculates global server positions mid-execution, causing network jitter to completely scramble the final sidebar layout.
Solution applied
Modified ensure_categories_and_channels to accumulate the intended sequential positions into a map across the operational loops. At the end of execution, a single atomic batch transaction is fired using guild.edit_channel_positions(positions=bulk_positions). This bypasses individual race conditions entirely, locking the layout into the perfect structural order specified by the incoming template.