Skip to content

Support larger accessibility text sizes#125

Open
garymc-MO wants to merge 1 commit into
EvanBacon:mainfrom
garymc-MO:codex/issue-123-larger-accessibility-sizes
Open

Support larger accessibility text sizes#125
garymc-MO wants to merge 1 commit into
EvanBacon:mainfrom
garymc-MO:codex/issue-123-larger-accessibility-sizes

Conversation

@garymc-MO

@garymc-MO garymc-MO commented Jul 2, 2026

Copy link
Copy Markdown

Adds ability to toggle on Larger Accessibility Sizes + extends Text Size slider:

image

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9118682e-464d-4146-92eb-aa2ac18eab81

📥 Commits

Reviewing files that changed from the base of the PR and between fd545ed and ac5f418.

📒 Files selected for processing (2)
  • packages/serve-sim/src/__tests__/simulator-settings-tool.test.tsx
  • packages/serve-sim/src/client/components/simulator-settings-tool.tsx

📝 Walkthrough

Walkthrough

This PR adds an "Accessibility Larger Sizes" toggle to the simulator text-size slider. Text-size categories are split into standard and accessibility sets, with new helper functions for mapping values, indices, and clamping. State wiring and tests are added accordingly.

Changes

Accessibility text-size toggle

Layer / File(s) Summary
Text-size category constants and helpers
packages/serve-sim/src/client/components/simulator-settings-tool.tsx
Adds STANDARD_TEXT_SIZE_CATEGORIES, ACCESSIBILITY_TEXT_SIZE_CATEGORIES, combined TEXT_SIZE_CATEGORIES, MAX_STANDARD_TEXT_SIZE_CATEGORY, and exported helpers isAccessibilityTextSize, textSizeCategories, textSizeIndex, textSizeAfterLargerAccessibilitySizesToggle.
Slider rendering via categories prop
packages/serve-sim/src/client/components/simulator-settings-tool.tsx
TextSizeSlider renders ticks from a passed-in categories prop instead of a fixed constant.
Toggle state and UI wiring
packages/serve-sim/src/client/components/simulator-settings-tool.tsx
Adds largerAccessibilitySizes state, resets it on refresh, auto-enables it from fetched simulator state, updates queue index translation via activeTextSizeCategories/activeTextSizeIndex, and adds the "Accessibility Larger Sizes" switch with clamped fallback on toggle-off.
Text size control tests
packages/serve-sim/src/__tests__/simulator-settings-tool.test.tsx
Adds a new test suite covering category lists, accessibility detection, index mapping, clamping, and toggle-off behavior.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • EvanBacon/serve-sim#96: Prior work on simulator-settings-tool.tsx/test file establishing the isIosRuntime coverage and imports that this PR extends.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding support for larger accessibility text sizes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant