feat: Add ARM64 architecture support to Dockerfile#5
Open
mgaldamez wants to merge 1 commit intoEvanTrow:mainfrom
Open
feat: Add ARM64 architecture support to Dockerfile#5mgaldamez wants to merge 1 commit intoEvanTrow:mainfrom
mgaldamez wants to merge 1 commit intoEvanTrow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
Dockerfileto include the necessary build dependencies (python3,make,g++) required for compiling native Node.js modules on ARM64 architectures.Without these dependencies,
npm installfails on the Alpine Linux base image when running on ARM64 becausenode-gypcannot compile the native bindings without a build toolchain.Changes
python3,make, andg++to theapk addcommand in the Dockerfile.