feat: Include previous left out changes into kubernetes PR#45
Merged
jessie-young merged 31 commits intomasterfrom Jan 24, 2025
Merged
feat: Include previous left out changes into kubernetes PR#45jessie-young merged 31 commits intomasterfrom
jessie-young merged 31 commits intomasterfrom
Conversation
…r, and support BYOC k8s clusters in daft-launcher Added docs for kuberay + daft installation, fixed minor linter issue
- they should be integrated into the Daft docs instead
Contributor
Author
|
@jessie-young, one thing to note is that I've moved all template and I've also created a new macro, |
Contributor
Author
|
@jessie-young, I've also added some (very basic) tests for ensuring that |
jessie-young
previously approved these changes
Jan 22, 2025
jessie-young
previously approved these changes
Jan 24, 2025
The merge-base changed after approval.
jessie-young
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In the kubernetes PR, some changes were left out:
daft listThis PR aims to merge those changes into the original Kubernetes PR so that that PR can be merged into master without any features missing.