chore: Cleanup Kubernetes PR and add tests#47
Merged
jessie-young merged 16 commits intomasterfrom Jan 24, 2025
Merged
Conversation
…r, and support BYOC k8s clusters in daft-launcher Added docs for kuberay + daft installation, fixed minor linter issue
jessie-young
previously approved these changes
Jan 23, 2025
raunakab
changed the title
jessie-young
previously approved these changes
Jan 23, 2025
Contributor
jessie-young
left a comment
jessie-young
left a comment
There was a problem hiding this comment.
One one minor comment but otherwise looks good
jessie-young
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to address some changes introduced in this PR.
Changes: