fix(cron): avoid heartbeat redelivery after successful delivery#165
Open
louiseboo wants to merge 2 commits into
Open
fix(cron): avoid heartbeat redelivery after successful delivery#165louiseboo wants to merge 2 commits into
louiseboo wants to merge 2 commits into
Conversation
Clarify conditions for enqueuing system events and early heartbeat ticks for cron runs.
louiseboo
marked this pull request as ready for review
July 21, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
What changed
deliver=true) Cron jobs that were already delivered.Root cause
A successful user-facing Cron run was delivered through the normal outlet and then emitted again as a system event. That event woke Heartbeat, which treated the same result as pending user-facing work and sent a second reminder.
Verification
uv run pytest -q tests/test_event_wake.py tests/test_cli_cron_handler.py -k 'not repl_assembly_cron_renders_once_via_clioutlet_not_broadcast'— 38 passed, 1 deselecteduv run ruff check raven/cli/_cron_handler.py tests/test_cli_cron_handler.py— passedThe deselected REPL assembly test already fails on untouched
upstream/main; this PR does not modify that path.