Conversation
ztravis
commented
Aug 19, 2024
| { | ||
| return( 0 ); | ||
| } | ||
| result = 0; |
Author
There was a problem hiding this comment.
This variable is used twice - just above, it's the return value of a submethod, but then it's also used later to represent the return value of this method itself. In between, we should make sure to reset it so that the first value doesn't accidentally get used for the second... this method is searching for a matching node and a value of 0 means no such node was found, so it's an appropriate default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for what I think are upstream issues.
The first is related to PSTs with name-to-id maps that don't have a GUID stream or an Entry stream. I don't think there is any reason to require these to be present or non-empty - in particular, the documentation indicates that a minimal name-to-id map only contains one property (https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-pst/5161fee7-42b1-4790-8337-411892b0032c), so it can reasonably not have the streams at all.
The second is related to an upstream bug where a return value is getting incorrectly reused, PR here: libyal#133