Update protocol removal notice in purefa_host.py#1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Problem
Users running ansible-core 2.19 or later receive the following error when using the
purefa_hostmodule with theprotocolparameter:Task failed: Module failed: collection_name must consist of two non-keyword identifiers separated by '.'Root Cause
In
plugins/modules/purefa_host.py, theprotocolparameter in theargument_spechas an incorrectly setremoved_from_collectionvalue:removed_from_collectionmust be a collection name innamespace.collection format. The value"1.13"is a version number that was incorrectly placed here, likely meaning "deprecated since collection version 1.13".
ansible-core 2.19 introduced strict runtime validation of this field via
validate_collection_name()inansible/module_utils/_internal/_validation.py. When a task passesprotocolas a parameter, ansible-core processes the deprecation, callsdeprecator_from_collection_name("1.13"), and raises aValueErrorbecause"1.13"is not a validnamespace.collectionstring. Older ansible-core versions silently ignored this malformed value.Fix
Set
removed_from_collectionto the correct collection name:ISSUE TYPE
COMPONENT NAME
purefa_host.py
ADDITIONAL INFORMATION
Closes #980