Б12-513 Kodik Igor#143
Open
yaigorian wants to merge 19 commits into
Open
Conversation
Owner
EvgrafovMichail
left a comment
EvgrafovMichail
left a comment
There was a problem hiding this comment.
Предварительно:
- Задача 1: 5/10 с возможностью повышения до 10/10
- Задача 2: 10/10
- Задача 3: 10/10
Но вы меняли версии библиотек в CI. Так что, пока не запущен CI на исходный настройках ничего выше 0 я поставить не могу
| if lhs[0].shape != rhs[0].shape: | ||
| raise ShapeMismatchError("lhs and rhs must have same shape") | ||
|
|
||
| return np.sqrt(np.sum((lhs[:, np.newaxis] - rhs) ** 2, 2)) |
Owner
There was a problem hiding this comment.
Пока поставлю 0 за этот код. Но вы можете подойти ко мне после пары, оспорить его и получить полный балл за эту функцию.
| if ordinates.size < 3: | ||
| raise ValueError("ordinates is too small") | ||
|
|
||
| indexes = np.arange(1, np.size(ordinates) - 1) |
Owner
There was a problem hiding this comment.
Можно было обратиться к атрибуту size вместо вызова функции:
Suggested change
| indexes = np.arange(1, np.size(ordinates) - 1) | |
| indexes = np.arange(1, ordinates.size - 1) |
| @@ -1,5 +1,5 @@ | |||
| matplotlib==3.8.0 | |||
| numpy==1.26.1 | |||
| matplotlib>=3.9.0 | |||
Owner
There was a problem hiding this comment.
Зачем это было сделано? Не надо трогать конфигурационные файлы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.