Б12-514, Осколков Олег#152
Open
OskolkovOleg wants to merge 18 commits into
Open
Conversation
Avshugan
reviewed
May 12, 2026
| ) -> None: | ||
| # ваш код | ||
| pass | ||
| if abscissa.shape != ordinates.shape: |
Collaborator
There was a problem hiding this comment.
Слишком большая функция получилась, тяжело читать код. Так еще и много повторяющегося кода
| def count_by_stage(records: list) -> np.ndarray: | ||
| stages = ["I", "II", "III", "IV"] | ||
| counts = np.zeros(len(stages), dtype=int) | ||
| for record in records: |
Collaborator
There was a problem hiding this comment.
Почему бы не использовать records.count?
Avshugan
reviewed
May 15, 2026
| from matplotlib.animation import FuncAnimation | ||
|
|
||
|
|
||
| def compute_signal(time: np.ndarray, modulation, fc: float) -> np.ndarray: |
| from matplotlib.animation import FuncAnimation | ||
|
|
||
|
|
||
| from functools import partial |
Avshugan
reviewed
May 15, 2026
| "outputs": [], | ||
| "source": [ | ||
| "# ваш код" | ||
| "titanic_data.isnull().sum()" |
Collaborator
There was a problem hiding this comment.
В части 2 можно было использовать аргумент inplace=True
| "outputs": [], | ||
| "source": [ | ||
| "# ваш код" | ||
| "titanic_data.isnull().sum()" |
Collaborator
There was a problem hiding this comment.
В части 3, как будто можно было сделать циклом и код был бы проще и не было столько повторений одного и того же кода
Avshugan
reviewed
May 16, 2026
| ) -> None: | ||
| # ваш код | ||
| pass | ||
| if abscissa.shape != ordinates.shape: |
Collaborator
There was a problem hiding this comment.
Нет названия графика, подписей к осям и легенды
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.