Б12-514, Баринов Михаил#173
Open
dmemsm wants to merge 11 commits into
Open
Conversation
Avshugan
reviewed
May 11, 2026
| return 0, 0 | ||
| pixels = image.flatten() | ||
| counts = np.zeros(256) | ||
| for color in range(256): |
Collaborator
There was a problem hiding this comment.
Есть np.unique, которая быстрее
| counts[color] = np.sum(pixels == color) | ||
|
|
||
| result_color, result_count = 0, 0 | ||
| for color in range(256): |
Collaborator
There was a problem hiding this comment.
Лучше было бы 256 вынести в константу, чтобы было сразу понятно, что вы имеете ввиду количество цветов, и еще вы далее используете 255, что является производной от этого числа
| if matrix.shape[0] != matrix.shape[1] or matrix.shape[0] != vector.shape[0]: | ||
| raise ShapeMismatchError | ||
|
|
||
| if np.linalg.det(matrix) == 0: |
Collaborator
There was a problem hiding this comment.
Во-первых, как вы можете помнить из первого семестра, делать == между 2 числами float - это неправильно.
Во-вторых, использование детерменанта для определения сингулярности матрицы - это ошибка, так как при вычислении детерменанта из-за компьютерных ошибок вы можете получить любое число.
Avshugan
reviewed
May 15, 2026
| from matplotlib.animation import FuncAnimation | ||
|
|
||
|
|
||
| def update_frame( |
Collaborator
There was a problem hiding this comment.
Нет названия графика, легенды
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.