Б12-514 Маланин Артем#178
Open
artemmalanin979-create wants to merge 42 commits into
Open
Conversation
Avshugan
reviewed
Mar 9, 2026
| min_mask = (center < left) & (center < right) | ||
| max_mask = (center > left) & (center > right) | ||
|
|
||
| mins = np.where(min_mask)[0] + 1 |
Collaborator
There was a problem hiding this comment.
np.where нельзя было использовать
artemmalanin979-create
force-pushed
the
main
branch
from
e3524e5 to
83b3e2e
Compare
Avshugan
reviewed
May 11, 2026
| ) | ||
| return (window_sums // window_area).astype(np.uint8) | ||
|
|
||
| if image.ndim == 3: |
Collaborator
There was a problem hiding this comment.
Можно было без if, это сильно бы упростило код
Avshugan
reviewed
May 12, 2026
| ) -> None: | ||
| # ваш код | ||
| pass | ||
| if abscissa.shape != ordinates.shape: |
Collaborator
There was a problem hiding this comment.
Слишком большая функция получилась, тяжело читать код.
|
|
||
| def count_stages(data: list) -> dict: | ||
| counts = {"I": 0, "II": 0, "III": 0, "IV": 0} | ||
| for item in data: |
Collaborator
There was a problem hiding this comment.
Почему бы не использовать data.count?
Avshugan
reviewed
May 15, 2026
| ) -> FuncAnimation: | ||
| # ваш код | ||
| return FuncAnimation() | ||
| local_time = np.arange(0, plot_duration, time_step) |
Avshugan
reviewed
May 15, 2026
| "id": "d7b00711", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "outputs": [ |
Collaborator
There was a problem hiding this comment.
А зачем 1ой части по разному брать размеры? Лучше везде shape использовать. Так нагляднее
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit с решением, как вы можете видеть, был сделан вовремя, а вот PR был создан только сейчас, прошу о снисходительности