Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors two methods to use explicit status code validation instead of relying on HttpClient's built-in error handling for stream operations.
- Replaces
GetStreamAsync()calls withGetAsync()followed by explicit status code validation - Adds
EnsureSignhostSuccessStatusCodeAsync()calls for consistent error handling - Manually extracts stream content from the response after validation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Modernizes the codebase by upgrading to .NET 10, enabling use of newer language features and APIs. Removes legacy netstandard1.4 support and related conditional logic to simplify maintenance. Improves compatibility with future .NET releases.
- Replaced Newtonsoft.Json with System.Text.Json for JSON serialization and deserialization across the API client. - Updated interfaces and classes to reflect consistent naming conventions (e.g., ISignHostApiClient to ISignhostApiClient). - Removed obsolete JsonConverter classes that were specific to Newtonsoft.Json. - Introduced centralized JSON serializer options in SignhostJsonSerializerOptions for consistent serialization behavior. - Added new JSON test resources for various transaction scenarios to ensure compatibility with the updated serialization logic.
ATimmeh33
force-pushed
the
fix/add-ensure-signhost-status-code
branch
from
690d2bf to
1c8c7b3
Compare
Collaborator
Author
|
Rebased on #153 |
Collaborator
Author
|
Cherry-picked in https://github.com/Evidos/SignhostClientLibrary/pull/162/files instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #153 - only last commit