fix(ci): repair failing audit and scorecard workflows#145
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Co-authored-by: UncleSp1d3r <unclesp1d3r@evilbitlabs.io>
dosubot
Bot
added
the
size:XS
Contributor
|
Related Documentation 1 document(s) may need updating based on files changed in this PR: DaemonEye Security Implementation PatternsView Suggested Changes@@ -576,7 +576,7 @@
[security.yml workflow runs cargo deny](https://github.com/EvilBit-Labs/DaemonEye/blob/0accb1ce956374dfc211a78d73043f52d6c64070/.github/workflows/security.yml):
- Executes after CI completion
- Daily scheduled execution
-- Runs `cargo deny check --config deny.ci.toml`
+- Runs `cargo deny check --config deny.toml`
- Also runs `cargo outdated` to detect outdated dependencies
[justfile provides security scan commands](https://github.com/EvilBit-Labs/DaemonEye/blob/0accb1ce956374dfc211a78d73043f52d6c64070/justfile#L230-L234):✅ Accepted Note: You must be authenticated to accept/decline updates. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull request overview
Repairs recurring CI failures in the repo’s security-focused GitHub Actions workflows by switching to an existing cargo-deny configuration file and updating a pinned github/codeql-action commit SHA used for SARIF upload.
Changes:
- Update Security workflow to run
cargo denyusingdeny.toml(repo-standard config). - Update Scorecard workflow to use a valid pinned commit SHA for
github/codeql-action/upload-sarif(v3).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/security.yml |
Points cargo deny check at the repository’s existing deny.toml config. |
.github/workflows/scorecard.yml |
Fixes the pinned upload-sarif action reference by replacing an invalid SHA with a valid github/codeql-action v3 commit. |
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 01e1af1. 🟢 All jobs passed!But CI Insights is watching 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes recurring CI failures by using the repository's existing cargo-deny config in the Security workflow and replacing an invalid pinned SHA in Scorecard's upload-sarif step with a valid github/codeql-action v3 commit.